-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add x/supply spec #836
Conversation
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
``` | ||
/supply/total/{denom} | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is missing example here, it should be like:
Example:
curl localhost:1317/supply/total/{denom}
Example Output:
1000040727987145688
|
||
``` | ||
/supply/circulating/{denom} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above.
Co-authored-by: Paul <p22626262@gmail.com>
Co-authored-by: Paul <p22626262@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
x/supply/spec/02_client.md
Outdated
``` | ||
|
||
#### total | ||
The `total` command allows users to query the total supply of a token given a denomination. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The `total` command allows users to query the total supply of a token given a denomination. | |
The `total` command allows users to query the total supply of a token given a denomination and an optional divider exponent. Based on the divider exponent, the total supply is displayed differently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of putting this here, since the divider exponent thing is related to all queries, I've put a note right inside the Query
section
``` | ||
|
||
#### circulating | ||
The `circulating` command allows users to query the circulating supply of a token given a denomination. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Description
This PR adds the
spec
folder inside thex/supply
module, containing the whole specification.Depends-On: #835
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change